Skip to content

Commit

Permalink
Documentation: Fix pci=config_acs= example
Browse files Browse the repository at this point in the history
The documentation currently says:

  config_acs=
                  Format:
                  <ACS flags>@<pci_dev>[; ...]
                  Specify one or more PCI devices (in the format
                  specified above) optionally prepended with flags
                  and separated by semicolons. The respective
                  capabilities will be enabled, disabled or
                  unchanged based on what is specified in
                  flags.
           (...)
                  For example,
                    pci=config_acs=10x
                  would configure all devices that support
                  ACS to enable P2P Request Redirect, disable
                  Translation Blocking, and leave Source
                  Validation unchanged from whatever power-up
                  or firmware set it to.

See the complete documentation at:

  https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html

However, a flag specification always needs to be suffixed with "@" and
a PCI valid device address, which is missing in this example. Also, to
configure all devices that support ACS, the flag needs to be suffixed
with "@pci:0:0", for the ACS support to be enabled.

Fix the documentation so the example is correct.

Link: https://lore.kernel.org/r/20240915-acs-v1-1-b9ee536ee9bd@daynix.com
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Akihiko Odaki authored and Bjorn Helgaas committed Jan 21, 2025
1 parent 188973e commit b388fac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Documentation/admin-guide/kernel-parameters.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4673,7 +4673,7 @@
'1' – force enabled
'x' – unchanged
For example,
pci=config_acs=10x
pci=config_acs=10x@pci:0:0
would configure all devices that support
ACS to enable P2P Request Redirect, disable
Translation Blocking, and leave Source
Expand Down

0 comments on commit b388fac

Please sign in to comment.