Skip to content

Commit

Permalink
Bluetooth: hci_bcm: Check for error irq
Browse files Browse the repository at this point in the history
For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.

Fixes: 0395ffc ("Bluetooth: hci_bcm: Add PM for BCM devices")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Jiasheng Jiang authored and Marcel Holtmann committed Jan 6, 2022
1 parent 710ad98 commit b38cd3b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/bluetooth/hci_bcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,12 @@ static int bcm_probe(struct platform_device *pdev)
return -ENOMEM;

dev->dev = &pdev->dev;
dev->irq = platform_get_irq(pdev, 0);

ret = platform_get_irq(pdev, 0);
if (ret < 0)
return ret;

dev->irq = ret;

/* Initialize routing field to an unused value */
dev->pcm_int_params[0] = 0xff;
Expand Down

0 comments on commit b38cd3b

Please sign in to comment.