Skip to content

Commit

Permalink
rcu: rcu_read_lock_bh_held(): disabling irqs also disables bh
Browse files Browse the repository at this point in the history
rcu_dereference_bh() doesnt know yet about hard irq being disabled, so
lockdep can trigger in netpoll_rx() after commit f0f9dea (netpoll:
Disable IRQ around RCU dereference in netpoll_rx)

Reported-by: Miles Lane <miles.lane@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Miles Lane <miles.lane@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
  • Loading branch information
Eric Dumazet authored and Paul E. McKenney committed Sep 23, 2010
1 parent 27c379f commit b3a084b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/rcupdate.h
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)
* Makes rcu_dereference_check() do the dirty work.
*/
#define rcu_dereference_bh(p) \
rcu_dereference_check(p, rcu_read_lock_bh_held())
rcu_dereference_check(p, rcu_read_lock_bh_held() || irqs_disabled())

/**
* rcu_dereference_sched - fetch RCU-protected pointer, checking for RCU-sched
Expand Down

0 comments on commit b3a084b

Please sign in to comment.