Skip to content

Commit

Permalink
x86: remove nx_enabled from fault.c
Browse files Browse the repository at this point in the history
On !PAE 32-bit, _PAGE_NX will be 0, making is_prefetch always
return early.  The test is sufficient on PAE as __supported_pte_mask
is updated in the same places as nx_enabled in init_32.c which also
takes disable_nx into account.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Harvey Harrison authored and Ingo Molnar committed Jan 30, 2008
1 parent c61e211 commit b406ac6
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions arch/x86/mm/fault.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,13 @@ static int is_prefetch(struct pt_regs *regs, unsigned long addr,
unsigned char *max_instr;

#ifdef CONFIG_X86_32
# ifdef CONFIG_X86_PAE
/* If it was a exec fault on NX page, ignore */
if (nx_enabled && (error_code & PF_INSTR))
if (!(__supported_pte_mask & _PAGE_NX))
return 0;
# else
return 0;
# endif
#else /* CONFIG_X86_64 */
#endif

/* If it was a exec fault on NX page, ignore */
if (error_code & PF_INSTR)
return 0;
#endif

instr = (unsigned char *)convert_ip_to_linear(current, regs);
max_instr = instr + 15;
Expand Down

0 comments on commit b406ac6

Please sign in to comment.