Skip to content

Commit

Permalink
shwdt: fix usage of mod_timer
Browse files Browse the repository at this point in the history
This patch fixes the usage of mod_timer and makes the driver usable.
mod_timer must be called with an absolute timeout in jiffies, the old
implementation used a relative timeout thus the hardware watchdog was
never triggered.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
David Engraf authored and Paul Mundt committed Jul 21, 2011
1 parent 3f7e5e2 commit b4300b7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/watchdog/shwdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
* misses its deadline, the kernel timer will allow the WDT to overflow.
*/
static int clock_division_ratio = WTCSR_CKS_4096;
#define next_ping_period(cks) msecs_to_jiffies(cks - 4)
#define next_ping_period(cks) (jiffies + msecs_to_jiffies(cks - 4))

static const struct watchdog_info sh_wdt_info;
static struct platform_device *sh_wdt_dev;
Expand Down

0 comments on commit b4300b7

Please sign in to comment.