Skip to content

Commit

Permalink
drm/xe: Cleanup has_flat_ccs handling
Browse files Browse the repository at this point in the history
The flag is set in XE_HP_FEATURES, but then overridden in all but one
xe_graphics_desc. Make it set only where needed.

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240904162238.2831202-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
  • Loading branch information
Lucas De Marchi committed Sep 6, 2024
1 parent 249df8c commit b43723f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/gpu/drm/xe/xe_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ static const struct xe_graphics_desc graphics_xelpp = {

#define XE_HP_FEATURES \
.has_range_tlb_invalidation = true, \
.has_flat_ccs = true, \
.dma_mask_size = 46, \
.va_bits = 48, \
.vm_max_level = 3
Expand All @@ -120,6 +119,8 @@ static const struct xe_graphics_desc graphics_xehpg = {

XE_HP_FEATURES,
.vram_flags = XE_VRAM_FLAGS_NEED64K,

.has_flat_ccs = 1,
};

static const struct xe_graphics_desc graphics_xehpc = {
Expand All @@ -145,7 +146,6 @@ static const struct xe_graphics_desc graphics_xehpc = {

.has_asid = 1,
.has_atomic_enable_pte_bit = 1,
.has_flat_ccs = 0,
.has_usm = 1,
};

Expand All @@ -156,7 +156,6 @@ static const struct xe_graphics_desc graphics_xelpg = {
BIT(XE_HW_ENGINE_CCS0),

XE_HP_FEATURES,
.has_flat_ccs = 0,
};

#define XE2_GFX_FEATURES \
Expand Down

0 comments on commit b43723f

Please sign in to comment.