Skip to content

Commit

Permalink
net: caif: use max() to simplify the code
Browse files Browse the repository at this point in the history
When processing the tail append of sk buffer, the final length needs
to be determined based on expectlen and addlen. Using max() here can
increase the readability of the code.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240822133908.1042240-4-lizetao1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Li Zetao authored and Jakub Kicinski committed Aug 26, 2024
1 parent 77f0cae commit b4985aa
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions net/caif/cfpkt_skbuff.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,8 @@ struct cfpkt *cfpkt_append(struct cfpkt *dstpkt,
if (unlikely(is_erronous(dstpkt) || is_erronous(addpkt))) {
return dstpkt;
}
if (expectlen > addlen)
neededtailspace = expectlen;
else
neededtailspace = addlen;

neededtailspace = max(expectlen, addlen);

if (dst->tail + neededtailspace > dst->end) {
/* Create a dumplicate of 'dst' with more tail space */
Expand Down

0 comments on commit b4985aa

Please sign in to comment.