Skip to content

Commit

Permalink
netfilter: ipset: fix incorret comparison in hash_netnet4_data_equal()
Browse files Browse the repository at this point in the history
Both sides of the comparison are the same, looks like a cut-and-paste error.

Spotted by Coverity.

Signed-off-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Dave Jones authored and Pablo Neira Ayuso committed Nov 25, 2013
1 parent 2c7a9dc commit b49faea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netfilter/ipset/ip_set_hash_netnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ hash_netnet4_data_equal(const struct hash_netnet4_elem *ip1,
u32 *multi)
{
return ip1->ipcmp == ip2->ipcmp &&
ip2->ccmp == ip2->ccmp;
ip1->ccmp == ip2->ccmp;
}

static inline int
Expand Down

0 comments on commit b49faea

Please sign in to comment.