Skip to content

Commit

Permalink
io_uring: add support for ftruncate
Browse files Browse the repository at this point in the history
Adds support for doing truncate through io_uring, eliminating
the need for applications to roll their own thread pool or offload
mechanism to be able to do non-blocking truncates.

Signed-off-by: Tony Solomonik <tony.solomonik@gmail.com>
Link: https://lore.kernel.org/r/20240202121724.17461-3-tony.solomonik@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Tony Solomonik authored and Jens Axboe committed Feb 9, 2024
1 parent 5f0d594 commit b4bb190
Show file tree
Hide file tree
Showing 5 changed files with 64 additions and 1 deletion.
1 change: 1 addition & 0 deletions include/uapi/linux/io_uring.h
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ enum io_uring_op {
IORING_OP_FUTEX_WAKE,
IORING_OP_FUTEX_WAITV,
IORING_OP_FIXED_FD_INSTALL,
IORING_OP_FTRUNCATE,

/* this goes last, obviously */
IORING_OP_LAST,
Expand Down
2 changes: 1 addition & 1 deletion io_uring/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ obj-$(CONFIG_IO_URING) += io_uring.o xattr.o nop.o fs.o splice.o \
statx.o net.o msg_ring.o timeout.o \
sqpoll.o fdinfo.o tctx.o poll.o \
cancel.o kbuf.o rsrc.o rw.o opdef.o \
notif.o waitid.o register.o
notif.o waitid.o register.o truncate.o
obj-$(CONFIG_IO_WQ) += io-wq.o
obj-$(CONFIG_FUTEX) += futex.o
10 changes: 10 additions & 0 deletions io_uring/opdef.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "rw.h"
#include "waitid.h"
#include "futex.h"
#include "truncate.h"

static int io_no_issue(struct io_kiocb *req, unsigned int issue_flags)
{
Expand Down Expand Up @@ -474,6 +475,12 @@ const struct io_issue_def io_issue_defs[] = {
.prep = io_install_fixed_fd_prep,
.issue = io_install_fixed_fd,
},
[IORING_OP_FTRUNCATE] = {
.needs_file = 1,
.hash_reg_file = 1,
.prep = io_ftruncate_prep,
.issue = io_ftruncate,
},
};

const struct io_cold_def io_cold_defs[] = {
Expand Down Expand Up @@ -712,6 +719,9 @@ const struct io_cold_def io_cold_defs[] = {
[IORING_OP_FIXED_FD_INSTALL] = {
.name = "FIXED_FD_INSTALL",
},
[IORING_OP_FTRUNCATE] = {
.name = "FTRUNCATE",
},
};

const char *io_uring_get_opcode(u8 opcode)
Expand Down
48 changes: 48 additions & 0 deletions io_uring/truncate.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
// SPDX-License-Identifier: GPL-2.0
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/fs.h>
#include <linux/file.h>
#include <linux/mm.h>
#include <linux/slab.h>
#include <linux/syscalls.h>
#include <linux/io_uring.h>

#include <uapi/linux/io_uring.h>

#include "../fs/internal.h"

#include "io_uring.h"
#include "truncate.h"

struct io_ftrunc {
struct file *file;
loff_t len;
};

int io_ftruncate_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
{
struct io_ftrunc *ft = io_kiocb_to_cmd(req, struct io_ftrunc);

if (sqe->rw_flags || sqe->addr || sqe->len || sqe->buf_index ||
sqe->splice_fd_in || sqe->addr3)
return -EINVAL;

ft->len = READ_ONCE(sqe->off);

req->flags |= REQ_F_FORCE_ASYNC;
return 0;
}

int io_ftruncate(struct io_kiocb *req, unsigned int issue_flags)
{
struct io_ftrunc *ft = io_kiocb_to_cmd(req, struct io_ftrunc);
int ret;

WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK);

ret = do_ftruncate(req->file, ft->len, 1);

io_req_set_res(req, ret, 0);
return IOU_OK;
}
4 changes: 4 additions & 0 deletions io_uring/truncate.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// SPDX-License-Identifier: GPL-2.0

int io_ftruncate_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe);
int io_ftruncate(struct io_kiocb *req, unsigned int issue_flags);

0 comments on commit b4bb190

Please sign in to comment.