Skip to content

Commit

Permalink
soc: qcom: ipa: Constify static qmi structs
Browse files Browse the repository at this point in the history
These are only used as input arguments to qmi_handle_init() which
accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
const to allow the compiler to put them in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20201122234031.33432-2-rikard.falkeborn@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Rikard Falkeborn authored and Jakub Kicinski committed Nov 25, 2020
1 parent fd89767 commit b5094a3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ipa/ipa_qmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned int node)
ipa_qmi->indication_sent = false;
}

static struct qmi_ops ipa_server_ops = {
static const struct qmi_ops ipa_server_ops = {
.bye = ipa_server_bye,
};

Expand Down Expand Up @@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct qmi_handle *qmi,
}

/* The server handles two request message types sent by the modem. */
static struct qmi_msg_handler ipa_server_msg_handlers[] = {
static const struct qmi_msg_handler ipa_server_msg_handlers[] = {
{
.type = QMI_REQUEST,
.msg_id = IPA_QMI_INDICATION_REGISTER,
Expand All @@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi,
}

/* The client handles one response message type sent by the modem. */
static struct qmi_msg_handler ipa_client_msg_handlers[] = {
static const struct qmi_msg_handler ipa_client_msg_handlers[] = {
{
.type = QMI_RESPONSE,
.msg_id = IPA_QMI_INIT_DRIVER,
Expand Down Expand Up @@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct qmi_service *svc)
return 0;
}

static struct qmi_ops ipa_client_ops = {
static const struct qmi_ops ipa_client_ops = {
.new_server = ipa_client_new_server,
};

Expand Down

0 comments on commit b5094a3

Please sign in to comment.