Skip to content

Commit

Permalink
net: mvneta: enable features before registering the driver
Browse files Browse the repository at this point in the history
It seems that the reason why the dev features were ignored was because
they were enabled after registeration.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
willy tarreau authored and David S. Miller committed Apr 8, 2013
1 parent f1ea3cd commit b50b72d
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/net/ethernet/marvell/mvneta.c
Original file line number Diff line number Diff line change
@@ -2771,16 +2771,17 @@ static int mvneta_probe(struct platform_device *pdev)

netif_napi_add(dev, &pp->napi, mvneta_poll, pp->weight);

dev->features = NETIF_F_SG | NETIF_F_IP_CSUM;
dev->hw_features |= NETIF_F_SG | NETIF_F_IP_CSUM;
dev->vlan_features |= NETIF_F_SG | NETIF_F_IP_CSUM;
dev->priv_flags |= IFF_UNICAST_FLT;

err = register_netdev(dev);
if (err < 0) {
dev_err(&pdev->dev, "failed to register\n");
goto err_deinit;
}

dev->features = NETIF_F_SG | NETIF_F_IP_CSUM;
dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM;
dev->priv_flags |= IFF_UNICAST_FLT;

netdev_info(dev, "mac: %pM\n", dev->dev_addr);

platform_set_drvdata(pdev, pp->dev);

0 comments on commit b50b72d

Please sign in to comment.