Skip to content

Commit

Permalink
nfc: s3fwrn5: Remove the max_payload
Browse files Browse the repository at this point in the history 
max_payload is unused.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Link: https://lore.kernel.org/r/20201117080824epcms2p36f70e06e2d8bd51d1af278b26ca65725@epcms2p3
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Bongsu Jeon authored and Jakub Kicinski committed Nov 19, 2020
1 parent aa8f2cb commit b50e296
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 1 addition & 2 deletions drivers/nfc/s3fwrn5/core.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ static struct nci_ops s3fwrn5_nci_ops = {
};

int s3fwrn5_probe(struct nci_dev **ndev, void *phy_id, struct device *pdev,
const struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload)
const struct s3fwrn5_phy_ops *phy_ops)
{
struct s3fwrn5_info *info;
int ret;
Expand All @@ -148,7 +148,6 @@ int s3fwrn5_probe(struct nci_dev **ndev, void *phy_id, struct device *pdev,
info->phy_id = phy_id;
info->pdev = pdev;
info->phy_ops = phy_ops;
info->max_payload = max_payload;
mutex_init(&info->mutex);

s3fwrn5_set_mode(info, S3FWRN5_MODE_COLD);
Expand Down
4 changes: 1 addition & 3 deletions drivers/nfc/s3fwrn5/i2c.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#define S3FWRN5_I2C_DRIVER_NAME "s3fwrn5_i2c"

#define S3FWRN5_I2C_MAX_PAYLOAD 32
#define S3FWRN5_EN_WAIT_TIME 150

struct s3fwrn5_i2c_phy {
Expand Down Expand Up @@ -248,8 +247,7 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client,
if (ret < 0)
return ret;

ret = s3fwrn5_probe(&phy->ndev, phy, &phy->i2c_dev->dev, &i2c_phy_ops,
S3FWRN5_I2C_MAX_PAYLOAD);
ret = s3fwrn5_probe(&phy->ndev, phy, &phy->i2c_dev->dev, &i2c_phy_ops);
if (ret < 0)
return ret;

Expand Down
3 changes: 1 addition & 2 deletions drivers/nfc/s3fwrn5/s3fwrn5.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ struct s3fwrn5_info {
struct device *pdev;

const struct s3fwrn5_phy_ops *phy_ops;
unsigned int max_payload;

struct s3fwrn5_fw_info fw_info;

Expand Down Expand Up @@ -79,7 +78,7 @@ static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb)
}

int s3fwrn5_probe(struct nci_dev **ndev, void *phy_id, struct device *pdev,
const struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload);
const struct s3fwrn5_phy_ops *phy_ops);
void s3fwrn5_remove(struct nci_dev *ndev);

int s3fwrn5_recv_frame(struct nci_dev *ndev, struct sk_buff *skb,
Expand Down

0 comments on commit b50e296

Please sign in to comment.