Skip to content

Commit

Permalink
macintosh/via-macii: Synchronous bus reset
Browse files Browse the repository at this point in the history
Make the reset operation synchronous, like the other ADB drivers.
The reset request is static data but callers may not know that.
This way the struct is not in use when the reset method returns.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Finn Thain authored and Michael Ellerman committed Oct 8, 2018
1 parent 2341629 commit b52dce8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/macintosh/via-macii.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ static int macii_reset_bus(void)
return 0;

/* Command = 0, Address = ignored */
adb_request(&req, NULL, 0, 1, ADB_BUSRESET);
adb_request(&req, NULL, ADBREQ_NOSEND, 1, ADB_BUSRESET);
macii_send_request(&req, 1);

/* Don't want any more requests during the Global Reset low time. */
udelay(3000);
Expand Down

0 comments on commit b52dce8

Please sign in to comment.