Skip to content

Commit

Permalink
platform/x86: dell-smbios: Correct some style warnings
Browse files Browse the repository at this point in the history
WARNING: function definition argument 'struct calling_interface_buffer *'
should also have an identifier name
+       int (*call_fn)(struct calling_interface_buffer *);

WARNING: Block comments use * on subsequent lines
+       /* 4 bytes of table header, plus 7 bytes of Dell header,
	plus at least
+          6 bytes of entry */

WARNING: Block comments use a trailing */ on a separate line
+          6 bytes of entry */

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
  • Loading branch information
Mario Limonciello authored and Darren Hart (VMware) committed Mar 9, 2018
1 parent 1cedc63 commit b535396
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/platform/x86/dell-smbios.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static DEFINE_MUTEX(smbios_mutex);
struct smbios_device {
struct list_head list;
struct device *device;
int (*call_fn)(struct calling_interface_buffer *);
int (*call_fn)(struct calling_interface_buffer *arg);
};

struct smbios_call {
Expand Down Expand Up @@ -352,8 +352,10 @@ static void __init parse_da_table(const struct dmi_header *dm)
struct calling_interface_structure *table =
container_of(dm, struct calling_interface_structure, header);

/* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
6 bytes of entry */
/*
* 4 bytes of table header, plus 7 bytes of Dell header
* plus at least 6 bytes of entry
*/

if (dm->length < 17)
return;
Expand Down

0 comments on commit b535396

Please sign in to comment.