Skip to content

Commit

Permalink
ARM: 7137/1: Fix error upon adding LL debug
Browse files Browse the repository at this point in the history
Upon adding new board LL debug support, if the resultant code
addition would not cause PC relative offset of "hexbuf" from
"adr r2, hexbuf" (+2) instruction to be representable in a
shifted 8-bit value (hence indirectly putting higher aligment
requirement on larger offsets), following error occurs,

arch/arm/kernel/debug.S: Assembler messages:
arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup

Fix it by bringing "hexbuf" closer so that "adr"
can have the offset.

Signed-off-by: Afzal Mohammed <afzal@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Afzal Mohammed authored and Russell King committed Oct 20, 2011
1 parent 628e111 commit b55fa18
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/kernel/debug.S
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ printhex: adr r2, hexbuf
b printascii
ENDPROC(printhex2)

hexbuf: .space 16

.ltorg

ENTRY(printascii)
Expand All @@ -175,5 +177,3 @@ ENTRY(printch)
mov r0, #0
b 1b
ENDPROC(printch)

hexbuf: .space 16

0 comments on commit b55fa18

Please sign in to comment.