Skip to content

Commit

Permalink
writeback: track if we're sleeping on progress in balance_dirty_pages()
Browse files Browse the repository at this point in the history
Note in the bdi_writeback structure whenever a task ends up sleeping
waiting for progress. We can use that information in the lower layers
to increase the priority of writes.

Signed-off-by: Jens Axboe <axboe@fb.com>
Reviewed-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Jens Axboe committed Nov 8, 2016
1 parent 8e1de26 commit b57d74a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/linux/backing-dev-defs.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ struct bdi_writeback {
struct list_head work_list;
struct delayed_work dwork; /* work item used for writeback */

unsigned long dirty_sleep; /* last wait */

struct list_head bdi_node; /* anchored at bdi->wb_list */

#ifdef CONFIG_CGROUP_WRITEBACK
Expand Down
1 change: 1 addition & 0 deletions mm/backing-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi,
spin_lock_init(&wb->work_lock);
INIT_LIST_HEAD(&wb->work_list);
INIT_DELAYED_WORK(&wb->dwork, wb_workfn);
wb->dirty_sleep = jiffies;

wb->congested = wb_congested_get_create(bdi, blkcg_id, gfp);
if (!wb->congested)
Expand Down
1 change: 1 addition & 0 deletions mm/page-writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -1778,6 +1778,7 @@ static void balance_dirty_pages(struct address_space *mapping,
pause,
start_time);
__set_current_state(TASK_KILLABLE);
wb->dirty_sleep = now;
io_schedule_timeout(pause);

current->dirty_paused_when = now + pause;
Expand Down

0 comments on commit b57d74a

Please sign in to comment.