Skip to content

Commit

Permalink
HID: hyperv: fix possible memory leak in mousevsc_probe()
Browse files Browse the repository at this point in the history
If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().

Fixes: 74c4fb0 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Yang Yingliang authored and Jiri Kosina committed Nov 2, 2022
1 parent 7f9dbf5 commit b5bcb94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-hyperv.c
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ static int mousevsc_probe(struct hv_device *device,

ret = hid_add_device(hid_dev);
if (ret)
goto probe_err1;
goto probe_err2;


ret = hid_parse(hid_dev);
Expand Down

0 comments on commit b5bcb94

Please sign in to comment.