Skip to content

Commit

Permalink
USB: gadget: bcm63xx: Re-use DEFINE_SHOW_ATTRIBUTE() macro
Browse files Browse the repository at this point in the history
...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Mar 9, 2018
1 parent efb85c4 commit b5c2939
Showing 1 changed file with 4 additions and 29 deletions.
33 changes: 4 additions & 29 deletions drivers/usb/gadget/udc/bcm63xx_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2158,6 +2158,7 @@ static int bcm63xx_usbd_dbg_show(struct seq_file *s, void *p)

return 0;
}
DEFINE_SHOW_ATTRIBUTE(bcm63xx_usbd_dbg);

/*
* bcm63xx_iudma_dbg_show - Show IUDMA status and descriptors.
Expand Down Expand Up @@ -2238,33 +2239,7 @@ static int bcm63xx_iudma_dbg_show(struct seq_file *s, void *p)

return 0;
}

static int bcm63xx_usbd_dbg_open(struct inode *inode, struct file *file)
{
return single_open(file, bcm63xx_usbd_dbg_show, inode->i_private);
}

static int bcm63xx_iudma_dbg_open(struct inode *inode, struct file *file)
{
return single_open(file, bcm63xx_iudma_dbg_show, inode->i_private);
}

static const struct file_operations usbd_dbg_fops = {
.owner = THIS_MODULE,
.open = bcm63xx_usbd_dbg_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};

static const struct file_operations iudma_dbg_fops = {
.owner = THIS_MODULE,
.open = bcm63xx_iudma_dbg_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};

DEFINE_SHOW_ATTRIBUTE(bcm63xx_iudma_dbg);

/**
* bcm63xx_udc_init_debugfs - Create debugfs entries.
Expand All @@ -2282,11 +2257,11 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc)
goto err_root;

usbd = debugfs_create_file("usbd", 0400, root, udc,
&usbd_dbg_fops);
&bcm63xx_usbd_dbg_fops);
if (!usbd)
goto err_usbd;
iudma = debugfs_create_file("iudma", 0400, root, udc,
&iudma_dbg_fops);
&bcm63xx_iudma_dbg_fops);
if (!iudma)
goto err_iudma;

Expand Down

0 comments on commit b5c2939

Please sign in to comment.