Skip to content

Commit

Permalink
mv643xx_eth: don't reset the rx coal timer on interface up
Browse files Browse the repository at this point in the history
Move SDMA configuration from interface up to port probe, to prevent
overwriting the receive coalescing timer value on interface up.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Lennert Buytenhek authored and David S. Miller committed Apr 8, 2009
1 parent 150899d commit b5e86db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/mv643xx_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -2274,8 +2274,6 @@ static void port_start(struct mv643xx_eth_private *mp)
pscr |= FORCE_LINK_PASS;
wrlp(mp, PORT_SERIAL_CONTROL, pscr);

wrlp(mp, SDMA_CONFIG, PORT_SDMA_CONFIG_DEFAULT_VALUE);

/*
* Configure TX path and queues.
*/
Expand Down Expand Up @@ -2957,6 +2955,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev)

netif_carrier_off(dev);

wrlp(mp, SDMA_CONFIG, PORT_SDMA_CONFIG_DEFAULT_VALUE);

set_rx_coal(mp, 250);
set_tx_coal(mp, 0);

Expand Down

0 comments on commit b5e86db

Please sign in to comment.