Skip to content

Commit

Permalink
iommu/mediatek: Constify iommu_ops
Browse files Browse the repository at this point in the history
iommu_ops are not supposed to change at runtime.
Functions 'iommu_device_set_ops' and 'bus_set_iommu' working with
const iommu_ops provided by <linux/iommu.h>. So mark the non-const
structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
(Change the title to iommu/mediatek: xx)
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Arvind Yadav authored and Joerg Roedel committed Nov 6, 2018
1 parent 6510223 commit b65f501
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/iommu/mtk_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ struct mtk_iommu_domain {
struct iommu_domain domain;
};

static struct iommu_ops mtk_iommu_ops;
static const struct iommu_ops mtk_iommu_ops;

static LIST_HEAD(m4ulist); /* List all the M4U HWs */

Expand Down Expand Up @@ -488,7 +488,7 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
return iommu_fwspec_add_ids(dev, args->args, 1);
}

static struct iommu_ops mtk_iommu_ops = {
static const struct iommu_ops mtk_iommu_ops = {
.domain_alloc = mtk_iommu_domain_alloc,
.domain_free = mtk_iommu_domain_free,
.attach_dev = mtk_iommu_attach_device,
Expand Down
4 changes: 2 additions & 2 deletions drivers/iommu/mtk_iommu_v1.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ static phys_addr_t mtk_iommu_iova_to_phys(struct iommu_domain *domain,
return pa;
}

static struct iommu_ops mtk_iommu_ops;
static const struct iommu_ops mtk_iommu_ops;

/*
* MTK generation one iommu HW only support one iommu domain, and all the client
Expand Down Expand Up @@ -524,7 +524,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data)
return 0;
}

static struct iommu_ops mtk_iommu_ops = {
static const struct iommu_ops mtk_iommu_ops = {
.domain_alloc = mtk_iommu_domain_alloc,
.domain_free = mtk_iommu_domain_free,
.attach_dev = mtk_iommu_attach_device,
Expand Down

0 comments on commit b65f501

Please sign in to comment.