Skip to content

Commit

Permalink
Blackfin: bf54x: don't ack GPIO ints when unmasking them
Browse files Browse the repository at this point in the history
When unmasking a GPIO interrupt on a BF54x part, the code will implicitly
ack any pending interrupts.  This is not what unmasking should do and can
cause people to miss interrupts from their devices, so punt the code.

Reported-by: Rutger Hofman <rutger@cs.vu.nl>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
  • Loading branch information
Mike Frysinger committed Jan 10, 2011
1 parent 25f3ff2 commit b66acb6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/blackfin/mach-common/ints-priority.c
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,6 @@ static void bfin_gpio_unmask_irq(unsigned int irq)
u32 pintbit = PINT_BIT(pint_val);
u32 bank = PINT_2_BANK(pint_val);

pint[bank]->request = pintbit;
pint[bank]->mask_set = pintbit;
}

Expand Down

0 comments on commit b66acb6

Please sign in to comment.