Skip to content

Commit

Permalink
cfg80211 debugfs: Cleanup some checkpatch issues
Browse files Browse the repository at this point in the history
This fixes the checkpatch.pl warnings:
* Macros should not use a trailing semicolon.
* Spaces required around that '='.
* Symbolic permissions 'S_IRUGO' are not preferred.

Signed-off-by: Dmitriy Pichugin <smokeman85@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Pichugin Dmitry authored and Johannes Berg committed Feb 8, 2017
1 parent bddb2af commit b699b71
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions net/wireless/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
static ssize_t name## _read(struct file *file, char __user *userbuf, \
size_t count, loff_t *ppos) \
{ \
struct wiphy *wiphy= file->private_data; \
struct wiphy *wiphy = file->private_data; \
char buf[buflen]; \
int res; \
\
Expand All @@ -29,14 +29,14 @@ static const struct file_operations name## _ops = { \
.read = name## _read, \
.open = simple_open, \
.llseek = generic_file_llseek, \
};
}

DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
wiphy->rts_threshold)
wiphy->rts_threshold);
DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d",
wiphy->frag_threshold);
DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d",
wiphy->retry_short)
wiphy->retry_short);
DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d",
wiphy->retry_long);

Expand Down Expand Up @@ -103,7 +103,7 @@ static const struct file_operations ht40allow_map_ops = {
};

#define DEBUGFS_ADD(name) \
debugfs_create_file(#name, S_IRUGO, phyd, &rdev->wiphy, &name## _ops);
debugfs_create_file(#name, 0444, phyd, &rdev->wiphy, &name## _ops)

void cfg80211_debugfs_rdev_add(struct cfg80211_registered_device *rdev)
{
Expand Down

0 comments on commit b699b71

Please sign in to comment.