Skip to content

Commit

Permalink
drm/i915/gvt: use pfn_valid for better checking
Browse files Browse the repository at this point in the history
Before get the page from pfn, use pfn_valid to check if pfn
is able to translate to page structure.

Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
  • Loading branch information
Chuanxiao Dong authored and Zhenyu Wang committed Mar 1, 2017
1 parent 858b0f5 commit b6b6fbc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/i915/gvt/kvmgt.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ static int gvt_dma_map_iova(struct intel_vgpu *vgpu, kvm_pfn_t pfn,
struct device *dev = &vgpu->gvt->dev_priv->drm.pdev->dev;
dma_addr_t daddr;

page = pfn_to_page(pfn);
if (is_error_page(page))
if (unlikely(!pfn_valid(pfn)))
return -EFAULT;

page = pfn_to_page(pfn);
daddr = dma_map_page(dev, page, 0, PAGE_SIZE,
PCI_DMA_BIDIRECTIONAL);
if (dma_mapping_error(dev, daddr))
Expand Down

0 comments on commit b6b6fbc

Please sign in to comment.