Skip to content

Commit

Permalink
io_uring: better to use REQ_F_IO_DRAIN for req->flags
Browse files Browse the repository at this point in the history
It's better to use REQ_F_IO_DRAIN for req->flags rather than
IOSQE_IO_DRAIN though they have same value.

Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20211125092103.224502-3-haoxu@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Hao Xu authored and Jens Axboe committed Nov 25, 2021
1 parent e302f10 commit b6c7db3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/io_uring.c
Original file line number Diff line number Diff line change
Expand Up @@ -7095,10 +7095,10 @@ static void io_init_req_drain(struct io_kiocb *req)
* If we need to drain a request in the middle of a link, drain
* the head request and the next request/link after the current
* link. Considering sequential execution of links,
* IOSQE_IO_DRAIN will be maintained for every request of our
* REQ_F_IO_DRAIN will be maintained for every request of our
* link.
*/
head->flags |= IOSQE_IO_DRAIN | REQ_F_FORCE_ASYNC;
head->flags |= REQ_F_IO_DRAIN | REQ_F_FORCE_ASYNC;
ctx->drain_next = true;
}
}
Expand Down Expand Up @@ -7149,7 +7149,7 @@ static int io_init_req(struct io_ring_ctx *ctx, struct io_kiocb *req,
if (unlikely(ctx->drain_next) && !ctx->submit_state.link.head) {
ctx->drain_next = false;
ctx->drain_active = true;
req->flags |= IOSQE_IO_DRAIN | REQ_F_FORCE_ASYNC;
req->flags |= REQ_F_IO_DRAIN | REQ_F_FORCE_ASYNC;
}
}

Expand Down

0 comments on commit b6c7db3

Please sign in to comment.