Skip to content

Commit

Permalink
drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()
Browse files Browse the repository at this point in the history
Unlock before returning on the error path.

Fixes: 5a028e8 ("drm/rockchip: vop2: Add support for rk3588")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240119190841.1619443-1-harshit.m.mogalapalli@oracle.com
  • Loading branch information
Harshit Mogalapalli authored and Heiko Stuebner committed Feb 13, 2024
1 parent b6802b6 commit b6ddaa6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1985,8 +1985,10 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
clock = vop2_set_intf_mux(vp, rkencoder->crtc_endpoint_id, polflags);
}

if (!clock)
if (!clock) {
vop2_unlock(vop2);
return;
}

if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA &&
!(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT))
Expand Down

0 comments on commit b6ddaa6

Please sign in to comment.