Skip to content

Commit

Permalink
net: link_watch: mark bonding link events urgent
Browse files Browse the repository at this point in the history
It takes 1sec for bond link down notification to hit user-space
when all slaves of the bond go down. 1sec is too long for
protocol daemons in user-space relying on bond notification
to recover (eg: multichassis lag implementations in user-space).
Since the link event code already marks team device port link events
 as urgent, this patch moves the code to cover all lag ports and master.

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Roopa Prabhu authored and David S. Miller committed Jan 24, 2018
1 parent 0542e13 commit b76f418
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/link_watch.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ static bool linkwatch_urgent_event(struct net_device *dev)
if (dev->ifindex != dev_get_iflink(dev))
return true;

if (dev->priv_flags & IFF_TEAM_PORT)
if (netif_is_lag_port(dev) || netif_is_lag_master(dev))
return true;

return netif_carrier_ok(dev) && qdisc_tx_changing(dev);
Expand Down

0 comments on commit b76f418

Please sign in to comment.