Skip to content

Commit

Permalink
drm/xe/huc: HuC is not supported on GTs that don't have video engines
Browse files Browse the repository at this point in the history
On MTL-style multi-gt platforms, the HuC is only available on the media
GT, so we need to consider it as not supported on the render GT.

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
  • Loading branch information
Daniele Ceraolo Spurio authored and Rodrigo Vivi committed Dec 21, 2023
1 parent 484ecff commit b77d8b5
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion drivers/gpu/drm/xe/xe_huc.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,19 @@ huc_to_guc(struct xe_huc *huc)

int xe_huc_init(struct xe_huc *huc)
{
struct xe_device *xe = huc_to_xe(huc);
struct xe_gt *gt = huc_to_gt(huc);
struct xe_tile *tile = gt_to_tile(gt);
struct xe_device *xe = gt_to_xe(gt);
int ret;

huc->fw.type = XE_UC_FW_TYPE_HUC;

/* On platforms with a media GT the HuC is only available there */
if (tile->media_gt && (gt != tile->media_gt)) {
xe_uc_fw_change_status(&huc->fw, XE_UC_FIRMWARE_NOT_SUPPORTED);
return 0;
}

ret = xe_uc_fw_init(&huc->fw);
if (ret)
goto out;
Expand Down

0 comments on commit b77d8b5

Please sign in to comment.