Skip to content

Commit

Permalink
[media] m920x: let GCC see 'ret' is used initialized
Browse files Browse the repository at this point in the history
Since commit 7543f34 ("[media] m920x:
factor out a m920x_write_seq() function") building m920x.o triggers this
GCC warning:
    drivers/media/usb/dvb-usb/m920x.c: In function ‘m920x_probe’:
    drivers/media/usb/dvb-usb/m920x.c:91:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized]
This warning is caused by m920x_write_seq(), which is apparently inlined
into m920x_probe(). It is clear why GCC thinks 'ret' may be used
uninitialized. But in practice the first seq->address will always be
non-zero when this function is called. That means we can change the
while()-do{} loop into a do{}-while() loop. And that suffices to make
GCC see that 'ret' will not be used uninitialized.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Paul Bolle authored and Mauro Carvalho Chehab committed Mar 18, 2013
1 parent 445ba89 commit b78a1f3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/media/usb/dvb-usb/m920x.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ static inline int m920x_write_seq(struct usb_device *udev, u8 request,
struct m920x_inits *seq)
{
int ret;
while (seq->address) {
do {
ret = m920x_write(udev, request, seq->data, seq->address);
if (ret != 0)
return ret;

seq++;
}
} while (seq->address);

return ret;
}
Expand Down

0 comments on commit b78a1f3

Please sign in to comment.