Skip to content

Commit

Permalink
wifi: mt76: mt7921: get rid of the false positive reset
Browse files Browse the repository at this point in the history
False positive reset would be possibly triggered by those commands we
applied in suspend with HZ MCU timeout, especially it happened when we
enabled kernel log in pm core to diagnose how much time we spend in each
driver during suspend procedure. So we enlarge the value and align the MCU
timeout as other commands we did to reduce the false positive reset.

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
  • Loading branch information
Sean Wang authored and Felix Fietkau committed Sep 15, 2022
1 parent 5473bdb commit b78f67b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 18 deletions.
7 changes: 1 addition & 6 deletions drivers/net/wireless/mediatek/mt76/mt7921/pci_mcu.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@ mt7921_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,
if (ret)
return ret;

if (cmd == MCU_UNI_CMD(HIF_CTRL) ||
cmd == MCU_UNI_CMD(SUSPEND) ||
cmd == MCU_UNI_CMD(OFFLOAD))
mdev->mcu.timeout = HZ;
else
mdev->mcu.timeout = 3 * HZ;
mdev->mcu.timeout = 3 * HZ;

if (cmd == MCU_CMD(FW_SCATTER))
txq = MT_MCUQ_FWDL;
Expand Down
7 changes: 1 addition & 6 deletions drivers/net/wireless/mediatek/mt76/mt7921/sdio_mcu.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,7 @@ mt7921s_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,
if (ret)
return ret;

if (cmd == MCU_UNI_CMD(HIF_CTRL) ||
cmd == MCU_UNI_CMD(SUSPEND) ||
cmd == MCU_UNI_CMD(OFFLOAD))
mdev->mcu.timeout = HZ;
else
mdev->mcu.timeout = 3 * HZ;
mdev->mcu.timeout = 3 * HZ;

if (cmd == MCU_CMD(FW_SCATTER))
type = MT7921_SDIO_FWDL;
Expand Down
7 changes: 1 addition & 6 deletions drivers/net/wireless/mediatek/mt76/mt7921/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,7 @@ mt7921u_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,
if (ret)
return ret;

if (cmd == MCU_UNI_CMD(HIF_CTRL) ||
cmd == MCU_UNI_CMD(SUSPEND) ||
cmd == MCU_UNI_CMD(OFFLOAD))
mdev->mcu.timeout = HZ;
else
mdev->mcu.timeout = 3 * HZ;
mdev->mcu.timeout = 3 * HZ;

if (cmd != MCU_CMD(FW_SCATTER))
ep = MT_EP_OUT_INBAND_CMD;
Expand Down

0 comments on commit b78f67b

Please sign in to comment.