Skip to content

Commit

Permalink
can: peak_usb: pcan_usb_get_serial(): unconditionally assign serial_n…
Browse files Browse the repository at this point in the history
…umber

The function serial_number is only called from one location with a
valid serial_number pointer. Remove not needed NULL pointer check.

Link: https://lore.kernel.org/r/20210406111622.1874957-10-mkl@pengutronix.de
Acked-by: Stephane Grosjean <s.grosjean@peak-system.com>
Tested-by: Stephane Grosjean <s.grosjean@peak-system.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Apr 13, 2021
1 parent 0a7d6cd commit b7a29d3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/can/usb/peak_usb/pcan_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,7 @@ static int pcan_usb_get_serial(struct peak_usb_device *dev, u32 *serial_number)
err = pcan_usb_wait_rsp(dev, PCAN_USB_CMD_SN, PCAN_USB_GET, args);
if (err)
return err;

if (serial_number)
*serial_number = le32_to_cpup((__le32 *)args);
*serial_number = le32_to_cpup((__le32 *)args);

return 0;
}
Expand Down

0 comments on commit b7a29d3

Please sign in to comment.