Revert "drm/amdkfd: Change vega10_noretry default to 1"

This reverts commit 3b1e4a9. This commit was causing stability issues due to a known CWSR HW problem. Bug: SWDEV-141899 Change-Id: Icfb6234be7c37b0b09169d10c14b13ba46587a9f Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
mariux64 · Jan 12, 2018 · b7aee45 · b7aee45
1 parent e56b858
commit b7aee45
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v9.c
@@ -62,8 +62,7 @@ static int update_qpd_v9(struct device_queue_manager *dqm,
 		qpd->sh_mem_config =
 				SH_MEM_ALIGNMENT_MODE_UNALIGNED <<
 					SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT;
-		if (vega10_noretry &&
-		    !dqm->dev->device_info->is_need_iommu_device)
+		if (vega10_noretry)
 			qpd->sh_mem_config |=
 				1 << SH_MEM_CONFIG__RETRY_DISABLE__SHIFT;
 

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c
@@ -84,10 +84,10 @@ module_param(ignore_crat, int, 0444);
 MODULE_PARM_DESC(ignore_crat,
 	"Ignore CRAT table during KFD initialization (0 = use CRAT (default), 1 = ignore CRAT)");
 
-int vega10_noretry = 1;
+int vega10_noretry;
 module_param_named(noretry, vega10_noretry, int, 0644);
 MODULE_PARM_DESC(noretry,
-	"Set sh_mem_config.retry_disable on Vega10 (0 = retry enabled, 1 = retry disabled (default))");
+	"Set sh_mem_config.retry_disable on Vega10 (0 = retry enabled (default), 1 = retry disabled)");
 
 int priv_cp_queues;
 module_param(priv_cp_queues, int, 0644);