Skip to content

Commit

Permalink
mm/vmalloc: be more explicit about supported gfp flags
Browse files Browse the repository at this point in the history
The core of the vmalloc allocator __vmalloc_area_node doesn't say
anything about gfp mask argument.  Not all gfp flags are supported
though.  Be more explicit about constraints.

Link: https://lkml.kernel.org/r/20211020082545.4830-1-mhocko@kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Neil Brown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Uladzislau Rezki <urezki@gmail.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Michal Hocko authored and Linus Torvalds committed Nov 6, 2021
1 parent 3252b1d commit b7d90e7
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions mm/vmalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2983,8 +2983,16 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
* @caller: caller's return address
*
* Allocate enough pages to cover @size from the page level
* allocator with @gfp_mask flags. Map them into contiguous
* kernel virtual space, using a pagetable protection of @prot.
* allocator with @gfp_mask flags. Please note that the full set of gfp
* flags are not supported. GFP_KERNEL would be a preferred allocation mode
* but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not
* supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka
* GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka
* __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported).
* __GFP_NOWARN can be used to suppress error messages about failures.
*
* Map them into contiguous kernel virtual space, using a pagetable
* protection of @prot.
*
* Return: the address of the area or %NULL on failure
*/
Expand Down

0 comments on commit b7d90e7

Please sign in to comment.