Skip to content

Commit

Permalink
rtl8xxxu: rtl8192eu_parse_efuse(): Use a pointer to the struct rtl819…
Browse files Browse the repository at this point in the history
…2eu_efuse

Make the code easier to read and less error prone by using a pointer
to the efuse.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
Jes Sorensen authored and Kalle Valo committed Mar 10, 2016
1 parent 4959444 commit b7dda34
Showing 1 changed file with 10 additions and 16 deletions.
26 changes: 10 additions & 16 deletions drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
Original file line number Diff line number Diff line change
Expand Up @@ -2288,33 +2288,27 @@ static int rtl8192cu_parse_efuse(struct rtl8xxxu_priv *priv)

static int rtl8192eu_parse_efuse(struct rtl8xxxu_priv *priv)
{
struct rtl8192eu_efuse *efuse = &priv->efuse_wifi.efuse8192eu;
int i;

if (priv->efuse_wifi.efuse8192eu.rtl_id != cpu_to_le16(0x8129))
if (efuse->rtl_id != cpu_to_le16(0x8129))
return -EINVAL;

ether_addr_copy(priv->mac_addr, priv->efuse_wifi.efuse8192eu.mac_addr);
ether_addr_copy(priv->mac_addr, efuse->mac_addr);

memcpy(priv->cck_tx_power_index_A,
priv->efuse_wifi.efuse8192eu.cck_tx_power_index_A,
memcpy(priv->cck_tx_power_index_A, efuse->cck_tx_power_index_A,
sizeof(priv->cck_tx_power_index_A));
memcpy(priv->cck_tx_power_index_B,
priv->efuse_wifi.efuse8192eu.cck_tx_power_index_B,
memcpy(priv->cck_tx_power_index_B, efuse->cck_tx_power_index_B,
sizeof(priv->cck_tx_power_index_B));

memcpy(priv->ht40_1s_tx_power_index_A,
priv->efuse_wifi.efuse8192eu.ht40_1s_tx_power_index_A,
memcpy(priv->ht40_1s_tx_power_index_A, efuse->ht40_1s_tx_power_index_A,
sizeof(priv->ht40_1s_tx_power_index_A));
memcpy(priv->ht40_1s_tx_power_index_B,
priv->efuse_wifi.efuse8192eu.ht40_1s_tx_power_index_B,
memcpy(priv->ht40_1s_tx_power_index_B, efuse->ht40_1s_tx_power_index_B,
sizeof(priv->ht40_1s_tx_power_index_B));

dev_info(&priv->udev->dev, "Vendor: %.7s\n",
priv->efuse_wifi.efuse8192eu.vendor_name);
dev_info(&priv->udev->dev, "Product: %.11s\n",
priv->efuse_wifi.efuse8192eu.device_name);
dev_info(&priv->udev->dev, "Serial: %.11s\n",
priv->efuse_wifi.efuse8192eu.serial);
dev_info(&priv->udev->dev, "Vendor: %.7s\n", efuse->vendor_name);
dev_info(&priv->udev->dev, "Product: %.11s\n", efuse->device_name);
dev_info(&priv->udev->dev, "Serial: %.11s\n", efuse->serial);

if (rtl8xxxu_debug & RTL8XXXU_DEBUG_EFUSE) {
unsigned char *raw = priv->efuse_wifi.raw;
Expand Down

0 comments on commit b7dda34

Please sign in to comment.