Skip to content

Commit

Permalink
net: lmc: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop p…
Browse files Browse the repository at this point in the history
…rofiles

dev_consume_skb_irq() should be called in lmc_interrupt() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.

Delete a redundant comment line in lmc_interrupt().

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yang Wei authored and David S. Miller committed Feb 25, 2019
1 parent c9d0c6e commit b84caee
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/wan/lmc/lmc_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1320,8 +1320,7 @@ static irqreturn_t lmc_interrupt (int irq, void *dev_instance) /*fold00*/
sc->lmc_device->stats.tx_packets++;
}

// dev_kfree_skb(sc->lmc_txq[i]);
dev_kfree_skb_irq(sc->lmc_txq[i]);
dev_consume_skb_irq(sc->lmc_txq[i]);
sc->lmc_txq[i] = NULL;

badtx++;
Expand Down

0 comments on commit b84caee

Please sign in to comment.