Skip to content

Commit

Permalink
ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats
Browse files Browse the repository at this point in the history
The transmit phase register value is never cleared during hw params.
So once hw params sets this bit to handle a two channel format, it
remains configured for dual-phase, which is not desirable for mono
playback.

Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
Link: https://lore.kernel.org/r/20201106145905.365903-1-bkylerussell@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Kyle Russell authored and Mark Brown committed Nov 18, 2020
1 parent a5ec7c9 commit b88b31f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/soc/pxa/mmp-sspa.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ static int mmp_sspa_hw_params(struct snd_pcm_substream *substream,
return -EINVAL;
}

sspa_ctrl &= ~SSPA_CTL_XPH;
if (dev->of_node || params_channels(params) == 2)
sspa_ctrl |= SSPA_CTL_XPH;

Expand Down

0 comments on commit b88b31f

Please sign in to comment.