Skip to content

Commit

Permalink
staging: iio: replace clk_get() with devm_clk_get()
Browse files Browse the repository at this point in the history
This patch replaces the clk_get() with devm_clk_get().Accordingly,modified
the error paths,rename error labels and removed clk_put() in probe() &
remove functions.

Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Gujulan Elango, Hari Prasath (H.) authored and Jonathan Cameron committed Feb 6, 2016
1 parent 3b31b78 commit b8cc27c
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions drivers/staging/iio/adc/spear_adc.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ static int spear_adc_probe(struct platform_device *pdev)
st->adc_base_spear3xx =
(struct adc_regs_spear3xx __iomem *)st->adc_base_spear6xx;

st->clk = clk_get(dev, NULL);
st->clk = devm_clk_get(dev, NULL);
if (IS_ERR(st->clk)) {
dev_err(dev, "failed getting clock\n");
goto errout1;
Expand All @@ -297,28 +297,28 @@ static int spear_adc_probe(struct platform_device *pdev)
ret = clk_prepare_enable(st->clk);
if (ret) {
dev_err(dev, "failed enabling clock\n");
goto errout2;
goto errout1;
}

irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
dev_err(dev, "failed getting interrupt resource\n");
ret = -EINVAL;
goto errout3;
goto errout2;
}

ret = devm_request_irq(dev, irq, spear_adc_isr, 0, SPEAR_ADC_MOD_NAME,
st);
if (ret < 0) {
dev_err(dev, "failed requesting interrupt\n");
goto errout3;
goto errout2;
}

if (of_property_read_u32(np, "sampling-frequency",
&st->sampling_freq)) {
dev_err(dev, "sampling-frequency missing in DT\n");
ret = -EINVAL;
goto errout3;
goto errout2;
}

/*
Expand Down Expand Up @@ -348,16 +348,14 @@ static int spear_adc_probe(struct platform_device *pdev)

ret = iio_device_register(indio_dev);
if (ret)
goto errout3;
goto errout2;

dev_info(dev, "SPEAR ADC driver loaded, IRQ %d\n", irq);

return 0;

errout3:
clk_disable_unprepare(st->clk);
errout2:
clk_put(st->clk);
clk_disable_unprepare(st->clk);
errout1:
iounmap(st->adc_base_spear6xx);
return ret;
Expand All @@ -370,7 +368,6 @@ static int spear_adc_remove(struct platform_device *pdev)

iio_device_unregister(indio_dev);
clk_disable_unprepare(st->clk);
clk_put(st->clk);
iounmap(st->adc_base_spear6xx);

return 0;
Expand Down

0 comments on commit b8cc27c

Please sign in to comment.