Skip to content

Commit

Permalink
Staging: batman-adv: remove redundant is_my_mac() check in route_unic…
Browse files Browse the repository at this point in the history
…ast_packet

Callers should check the if the received packet is for us before it
calls route_unicast_packet.

Signed-off-by: Andreas Langer <an.langer@gmx.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andreas Langer authored and Greg Kroah-Hartman committed Nov 29, 2010
1 parent f3cc759 commit b8cd754
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/staging/batman-adv/routing.c
Original file line number Diff line number Diff line change
Expand Up @@ -1131,12 +1131,6 @@ static int route_unicast_packet(struct sk_buff *skb,

unicast_packet = (struct unicast_packet *)skb->data;

/* packet for me */
if (is_my_mac(unicast_packet->dest)) {
interface_rx(recv_if->soft_iface, skb, hdr_size);
return NET_RX_SUCCESS;
}

/* TTL exceeded */
if (unicast_packet->ttl < 2) {
pr_debug("Warning - can't forward unicast packet from %pM to "
Expand Down Expand Up @@ -1170,7 +1164,6 @@ static int route_unicast_packet(struct sk_buff *skb,
return NET_RX_DROP;

unicast_packet = (struct unicast_packet *)skb->data;
ethhdr = (struct ethhdr *)skb_mac_header(skb);

/* decrement ttl */
unicast_packet->ttl--;
Expand Down

0 comments on commit b8cd754

Please sign in to comment.