Skip to content

Commit

Permalink
crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init()
Browse files Browse the repository at this point in the history
->src_nents and ->dst_nents are unsigned so they can't be less than
zero.  I fixed this by introducing a temporary "nents" variable.

Fixes: d293b64 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Dan Carpenter authored and Herbert Xu committed Apr 25, 2016
1 parent 3639ca8 commit b908bd3
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions drivers/crypto/mxc-scc.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,18 +210,21 @@ static int mxc_scc_ablkcipher_req_init(struct ablkcipher_request *req,
struct mxc_scc_ctx *ctx)
{
struct mxc_scc *scc = ctx->scc;
int nents;

ctx->src_nents = sg_nents_for_len(req->src, req->nbytes);
if (ctx->src_nents < 0) {
nents = sg_nents_for_len(req->src, req->nbytes);
if (nents < 0) {
dev_err(scc->dev, "Invalid number of src SC");
return ctx->src_nents;
return nents;
}
ctx->src_nents = nents;

ctx->dst_nents = sg_nents_for_len(req->dst, req->nbytes);
if (ctx->dst_nents < 0) {
nents = sg_nents_for_len(req->dst, req->nbytes);
if (nents < 0) {
dev_err(scc->dev, "Invalid number of dst SC");
return ctx->dst_nents;
return nents;
}
ctx->dst_nents = nents;

ctx->size = 0;
ctx->offset = 0;
Expand Down

0 comments on commit b908bd3

Please sign in to comment.