Skip to content

Commit

Permalink
KVM: selftests: Drop helpers for getting specific KVM supported CPUID…
Browse files Browse the repository at this point in the history
… entry

Drop kvm_get_supported_cpuid_entry() and its inner helper now that all
known usage can use X86_FEATURE_*, X86_PROPERTY_*, X86_PMU_FEATURE_*, or
the dedicated Family/Model helpers.  Providing "raw" access to CPUID
leafs is undesirable as it encourages open coding CPUID checks, which is
often error prone and not self-documenting.

No functional change intended.

Signed-off-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221006005125.680782-13-seanjc@google.com
  • Loading branch information
Sean Christopherson committed Nov 17, 2022
1 parent 074e9d4 commit b941ba2
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions tools/testing/selftests/kvm/include/x86_64/processor.h
Original file line number Diff line number Diff line change
Expand Up @@ -902,17 +902,6 @@ static inline void vcpu_clear_cpuid_feature(struct kvm_vcpu *vcpu,
vcpu_set_or_clear_cpuid_feature(vcpu, feature, false);
}

static inline const struct kvm_cpuid_entry2 *__kvm_get_supported_cpuid_entry(uint32_t function,
uint32_t index)
{
return get_cpuid_entry(kvm_get_supported_cpuid(), function, index);
}

static inline const struct kvm_cpuid_entry2 *kvm_get_supported_cpuid_entry(uint32_t function)
{
return __kvm_get_supported_cpuid_entry(function, 0);
}

uint64_t vcpu_get_msr(struct kvm_vcpu *vcpu, uint64_t msr_index);
int _vcpu_set_msr(struct kvm_vcpu *vcpu, uint64_t msr_index, uint64_t msr_value);

Expand Down

0 comments on commit b941ba2

Please sign in to comment.