Skip to content

Commit

Permalink
can: flexcan: flexcan_mailbox_read() make use of flexcan_write64() to…
Browse files Browse the repository at this point in the history
… mark the mailbox as read

In the previous patch the function flexcan_write64() was introduced.

This patch replaces the open coded variant in flexcan_mailbox_read()
that marks a mailbox as read, by a single call to flexcan_write64().

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Nov 11, 2019
1 parent b87c28b commit b9468ad
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/net/can/flexcan.c
Original file line number Diff line number Diff line change
@@ -883,15 +883,10 @@ static struct sk_buff *flexcan_mailbox_read(struct can_rx_offload *offload,
}

mark_as_read:
if (priv->devtype_data->quirks & FLEXCAN_QUIRK_USE_OFF_TIMESTAMP) {
/* Clear IRQ */
if (n < 32)
priv->write(BIT(n), &regs->iflag1);
else
priv->write(BIT(n - 32), &regs->iflag2);
} else {
if (priv->devtype_data->quirks & FLEXCAN_QUIRK_USE_OFF_TIMESTAMP)
flexcan_write64(priv, FLEXCAN_IFLAG_MB(n), &regs->iflag1);
else
priv->write(FLEXCAN_IFLAG_RX_FIFO_AVAILABLE, &regs->iflag1);
}

/* Read the Free Running Timer. It is optional but recommended
* to unlock Mailbox as soon as possible and make it available

0 comments on commit b9468ad

Please sign in to comment.