Skip to content

Commit

Permalink
samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh
Browse files Browse the repository at this point in the history
The below path error can occur:

  # ./xdp2skb_meta.sh --dev eth0 --list
  ./xdp2skb_meta.sh: line 61: /usr/sbin/tc: No such file or directory

So just use command names instead of absolute paths of tc and ip.
In addition, it allow callers to redefine $TC and $IP paths

Fixes: 36e04a2 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB")
Reviewed-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
  • Loading branch information
Taeung Song authored and Daniel Borkmann committed Jul 10, 2018
1 parent f292b87 commit b9626f4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions samples/bpf/xdp2skb_meta.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
BPF_FILE=xdp2skb_meta_kern.o
DIR=$(dirname $0)

export TC=/usr/sbin/tc
export IP=/usr/sbin/ip
[ -z "$TC" ] && TC=tc
[ -z "$IP" ] && IP=ip

function usage() {
echo ""
Expand Down Expand Up @@ -53,7 +53,7 @@ function _call_cmd() {
local allow_fail="$2"
shift 2
if [[ -n "$VERBOSE" ]]; then
echo "$(basename $cmd) $@"
echo "$cmd $@"
fi
if [[ -n "$DRYRUN" ]]; then
return
Expand Down

0 comments on commit b9626f4

Please sign in to comment.