Skip to content

Commit

Permalink
bgmac: increase rx ring size from 511 to 512
Browse files Browse the repository at this point in the history
Limiting it to 511 looks like a failed attempt at leaving one descriptor
empty to allow the hardware to stop processing a buffer that has not
been prepared yet. However, this doesn't work because this affects the
total ring size as well

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Felix Fietkau authored and David S. Miller committed Apr 14, 2015
1 parent 6a6c708 commit b965055
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/broadcom/bgmac.h
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@
#define BGMAC_MAX_RX_RINGS 1

#define BGMAC_TX_RING_SLOTS 128
#define BGMAC_RX_RING_SLOTS 512 - 1 /* Why -1? Well, Broadcom does that... */
#define BGMAC_RX_RING_SLOTS 512

#define BGMAC_RX_HEADER_LEN 28 /* Last 24 bytes are unused. Well... */
#define BGMAC_RX_FRAME_OFFSET 30 /* There are 2 unused bytes between header and real data */
Expand Down

0 comments on commit b965055

Please sign in to comment.