Skip to content

Commit

Permalink
korina: fix usage of driver_data
Browse files Browse the repository at this point in the history
Using platform_set_drvdata() here makes no sense, since the driver_data
field has already been filled with valuable data (i.e. the MAC address).
Also having driver_data point to the net_device is rather pointless
since struct korina_device contains an apropriate field for it.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Phil Sutter authored and David S. Miller committed Jan 15, 2009
1 parent 0ef0045 commit b96ecfa
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/korina.c
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,6 @@ static int korina_probe(struct platform_device *pdev)
return -ENOMEM;
}
SET_NETDEV_DEV(dev, &pdev->dev);
platform_set_drvdata(pdev, dev);
lp = netdev_priv(dev);

bif->dev = dev;
Expand Down

0 comments on commit b96ecfa

Please sign in to comment.