Skip to content

Commit

Permalink
r8169: remove unneeded rpm ops in rtl_shutdown
Browse files Browse the repository at this point in the history
This patch reverts commit 2a15cd2 "r8169: runtime resume before
shutdown" from 2012. Few months after this change the underlying issue
was solved in the PCI core with commit 3ff2de9 "PCI/PM: Resume
device before shutdown".

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Jan 9, 2018
1 parent fdb533c commit b9aa1c7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -8195,9 +8195,6 @@ static void rtl_shutdown(struct pci_dev *pdev)
{
struct net_device *dev = pci_get_drvdata(pdev);
struct rtl8169_private *tp = netdev_priv(dev);
struct device *d = &pdev->dev;

pm_runtime_get_sync(d);

rtl8169_net_suspend(dev);

Expand All @@ -8215,8 +8212,6 @@ static void rtl_shutdown(struct pci_dev *pdev)
pci_wake_from_d3(pdev, true);
pci_set_power_state(pdev, PCI_D3hot);
}

pm_runtime_put_noidle(d);
}

static void rtl_remove_one(struct pci_dev *pdev)
Expand Down

0 comments on commit b9aa1c7

Please sign in to comment.