Skip to content

Commit

Permalink
regulator: core: silence warning: "VDD1: ramp_delay not set"
Browse files Browse the repository at this point in the history 
commit 73e705b ("regulator: core: Add set_voltage_time op")

introduced a new rdev_warn() if the ramp_delay is 0.

Apparently, on omap3/twl4030 platforms with dynamic voltage
management this results in non-ending spurious messages like

[  511.143066] VDD1: ramp_delay not set
[  511.662322] VDD1: ramp_delay not set
[  513.903625] VDD1: ramp_delay not set
[  514.222198] VDD1: ramp_delay not set
[  517.062835] VDD1: ramp_delay not set
[  517.382568] VDD1: ramp_delay not set
[  520.142791] VDD1: ramp_delay not set
[  520.502593] VDD1: ramp_delay not set
[  523.062896] VDD1: ramp_delay not set
[  523.362701] VDD1: ramp_delay not set
[  526.143035] VDD1: ramp_delay not set

I have observed this on GTA04 while it is reported to occur on
N900 as well: https://bugzilla.kernel.org/show_bug.cgi?id=178371

This patch makes the warning appear only in debugging mode.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
H. Nikolaus Schaller authored and Mark Brown committed Oct 28, 2016
1 parent 1001354 commit ba14fa1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/core.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2754,7 +2754,7 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
ramp_delay = rdev->desc->ramp_delay;

if (ramp_delay == 0) {
rdev_warn(rdev, "ramp_delay not set\n");
rdev_dbg(rdev, "ramp_delay not set\n");
return 0;
}

Expand Down

0 comments on commit ba14fa1

Please sign in to comment.