Skip to content

Commit

Permalink
usb: core: driver: fix stray tabs in error messages
Browse files Browse the repository at this point in the history
Commit 8bb54ab ("usbcore: add usb_device_driver definition") added
the printk() calls with the error massages spoilt due to the stray tabs
in the middle. Remove these tabs and convert printk() calls to pr_err()
for consistency with the other code, while at it.

Fixes: 8bb54ab ("usbcore: add usb_device_driver definition")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/4beb55c4-eb34-7744-155f-033b8f527e23@omprussia.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sergey Shtylyov authored and Greg Kroah-Hartman committed Sep 4, 2020
1 parent 5fedf0d commit bb0634e
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/usb/core/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -973,8 +973,7 @@ int usb_register_device_driver(struct usb_device_driver *new_udriver,
bus_for_each_dev(&usb_bus_type, NULL, new_udriver,
__usb_bus_reprobe_drivers);
} else {
printk(KERN_ERR "%s: error %d registering device "
" driver %s\n",
pr_err("%s: error %d registering device driver %s\n",
usbcore_name, retval, new_udriver->name);
}

Expand Down Expand Up @@ -1050,9 +1049,8 @@ int usb_register_driver(struct usb_driver *new_driver, struct module *owner,
out_newid:
driver_unregister(&new_driver->drvwrap.driver);

printk(KERN_ERR "%s: error %d registering interface "
" driver %s\n",
usbcore_name, retval, new_driver->name);
pr_err("%s: error %d registering interface driver %s\n",
usbcore_name, retval, new_driver->name);
goto out;
}
EXPORT_SYMBOL_GPL(usb_register_driver);
Expand Down

0 comments on commit bb0634e

Please sign in to comment.