Skip to content

Commit

Permalink
mmc: omap_hsmmc: remove un-initialized callbacks from platform data
Browse files Browse the repository at this point in the history
these callbacks are not set, probably legacy omap 1/2 features

Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Andreas Fenkart authored and Ulf Hansson committed Nov 26, 2014
1 parent a74fecd commit bb09d15
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
15 changes: 1 addition & 14 deletions drivers/mmc/host/omap_hsmmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2204,18 +2204,10 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
goto err_irq;
}

if (pdata->init != NULL) {
if (pdata->init(&pdev->dev) != 0) {
dev_err(mmc_dev(host->mmc),
"Unable to configure MMC IRQs\n");
goto err_irq;
}
}

if (omap_hsmmc_have_reg() && !mmc_slot(host).set_power) {
ret = omap_hsmmc_reg_get(host);
if (ret)
goto err_reg;
goto err_irq;
host->use_reg = 1;
}

Expand Down Expand Up @@ -2278,9 +2270,6 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
err_irq_cd:
if (host->use_reg)
omap_hsmmc_reg_put(host);
err_reg:
if (host->pdata->cleanup)
host->pdata->cleanup(&pdev->dev);
err_irq:
if (host->tx_chan)
dma_release_channel(host->tx_chan);
Expand All @@ -2306,8 +2295,6 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
mmc_remove_host(host->mmc);
if (host->use_reg)
omap_hsmmc_reg_put(host);
if (host->pdata->cleanup)
host->pdata->cleanup(&pdev->dev);

if (host->tx_chan)
dma_release_channel(host->tx_chan);
Expand Down
9 changes: 0 additions & 9 deletions include/linux/platform_data/hsmmc-omap.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ struct omap_hsmmc_platform_data {
* maximum frequency on the MMC bus */
unsigned int max_freq;

/* switch the bus to a new slot */
int (*switch_slot)(struct device *dev, int slot);
/* initialize board-specific MMC functionality, can be NULL if
* not supported */
int (*init)(struct device *dev);
void (*cleanup)(struct device *dev);
void (*shutdown)(struct device *dev);

/* To handle board related suspend/resume functionality for MMC */
int (*suspend)(struct device *dev, int slot);
int (*resume)(struct device *dev, int slot);
Expand Down Expand Up @@ -97,7 +89,6 @@ struct omap_hsmmc_platform_data {
int switch_pin; /* gpio (card detect) */
int gpio_wp; /* gpio (write protect) */

int (*set_bus_mode)(struct device *dev, int slot, int bus_mode);
int (*set_power)(struct device *dev, int slot,
int power_on, int vdd);
int (*get_ro)(struct device *dev, int slot);
Expand Down

0 comments on commit bb09d15

Please sign in to comment.