Skip to content

Commit

Permalink
drm/msm: remove python 3.9 dependency for compiling msm
Browse files Browse the repository at this point in the history
Since commit 5acf491 ("drm/msm: import gen_header.py script from Mesa"),
compilation is broken on machines having python versions older than 3.9
due to dependency on argparse.BooleanOptionalAction.

Switch to use simple bool for the validate flag to remove the dependency.

Fixes: 5acf491 ("drm/msm: import gen_header.py script from Mesa")
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240507230440.3384949-1-quic_abhinavk@quicinc.com
  • Loading branch information
Abhinav Kumar authored and Thierry Reding committed May 30, 2024
1 parent b62c150 commit bb19535
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/gpu/drm/msm/registers/gen_header.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ def add_all_usages(self, reg, usages):
self.variants.add(reg.domain)

def do_validate(self, schemafile):
if self.validate == False:
if not self.validate:
return

try:
Expand Down Expand Up @@ -948,7 +948,8 @@ def main():
parser = argparse.ArgumentParser()
parser.add_argument('--rnn', type=str, required=True)
parser.add_argument('--xml', type=str, required=True)
parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
parser.add_argument('--validate', default=False, action='store_true')
parser.add_argument('--no-validate', dest='validate', action='store_false')

subparsers = parser.add_subparsers()
subparsers.required = True
Expand Down

0 comments on commit bb19535

Please sign in to comment.