Skip to content

Commit

Permalink
[SCSI] megaraid_sas: remove sysfs poll_mode_io world writeable permis…
Browse files Browse the repository at this point in the history
…sions

/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being
world-writable, which seems bad (letting any user affect kernel driver
behavior).

This turns off group and user write permissions, so that on typical
production systems only root can write to it.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Bryn M. Reeves authored and Linus Torvalds committed Jan 13, 2010
1 parent 90aeb7c commit bb7d3f2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/megaraid/megaraid_sas.c
Original file line number Diff line number Diff line change
Expand Up @@ -4046,7 +4046,7 @@ megasas_aen_polling(struct work_struct *work)
}


static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO,
static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR,
megasas_sysfs_show_poll_mode_io,
megasas_sysfs_set_poll_mode_io);

Expand Down

0 comments on commit bb7d3f2

Please sign in to comment.