Skip to content

Commit

Permalink
Merge tag 'for-linus-20180610' of git://git.kernel.dk/linux-block
Browse files Browse the repository at this point in the history
Pull block flush handling fix from Jens Axboe:
 "Single fix that we should merge now, fixing a regression in queuing
  flush request, accessing request flags after calling the end_request
  handler"

* tag 'for-linus-20180610' of git://git.kernel.dk/linux-block:
  block: fix use-after-free in block flush handling
  • Loading branch information
Linus Torvalds committed Jun 10, 2018
2 parents d82991a + 190b02e commit bbaa101
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion block/blk-flush.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,11 @@ static bool blk_flush_complete_seq(struct request *rq,
struct request_queue *q = rq->q;
struct list_head *pending = &fq->flush_queue[fq->flush_pending_idx];
bool queued = false, kicked;
unsigned int cmd_flags;

BUG_ON(rq->flush.seq & seq);
rq->flush.seq |= seq;
cmd_flags = rq->cmd_flags;

if (likely(!error))
seq = blk_flush_cur_seq(rq);
Expand Down Expand Up @@ -212,7 +214,7 @@ static bool blk_flush_complete_seq(struct request *rq,
BUG();
}

kicked = blk_kick_flush(q, fq, rq->cmd_flags);
kicked = blk_kick_flush(q, fq, cmd_flags);
return kicked | queued;
}

Expand Down

0 comments on commit bbaa101

Please sign in to comment.